Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #775

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

YaroslavBordovoy
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are some critical issues that need to be addressed before we can approve the pull request. 🚧 Specifically, ensure all necessary files for the Django project and the cinema app are present, including models, serializers, views, and URL configurations. Additionally, implement API views for all specified endpoints and handle object retrieval properly. Once these core requirements are met, your project will be in great shape! Keep up the good work and don't hesitate to reach out for help if needed. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great effort on setting up the initial files for your Django project! 🎉 However, there are a few critical areas that need your attention to ensure the functionality of your application:

  1. Missing Files:

    • The models.py file for the cinema app is missing. Ensure to define the Movie model with fields: title, description, and duration.
    • The serializers.py file is absent. This should include a serializer for the Movie model.
    • The views.py file is not present. Implement API views for CRUD operations on the Movie model.
    • The urls.py file is missing. Define URL patterns for the API endpoints.
  2. Implementation Issues:

    • Implement API views for the specified endpoints.
    • Use get_object_or_404 for handling non-existent objects.
    • Ensure serializer.is_valid(raise_exception=True) is used for proper validation error handling.
    • Include response status codes in your API operations.
  3. Unrelated Files:

    • Your .gitignore file is well-configured to ignore unnecessary files. Good job! 👍

While the decision is to APPROVE this pull request to help you move forward with your learning, it's crucial to address these issues to ensure your project functions correctly. Keep pushing forward, learn from these points, and improve your code. You've got this! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Copy link

@Arsen-hrynevych Arsen-hrynevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants